Skip to content

Commit a725574

Browse files
committed
Address Mehrdad's PR comments
1 parent ef00c0d commit a725574

File tree

3 files changed

+2
-28
lines changed

3 files changed

+2
-28
lines changed

apps/microtvm/reference-vm/arduino/Vagrantfile

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -63,27 +63,4 @@ Vagrant.configure("2") do |config|
6363
end
6464
end
6565

66-
config.vm.provider "parallels" do |prl, overrides|
67-
prl.name = vm_name
68-
prl.cpus = num_cores
69-
prl.memory = ram_bytes
70-
prl.update_guest_tools = true
71-
prl.customize ["set", :id, "--support-usb30", "on"]
72-
dirs_to_mount.each do |d|
73-
overrides.vm.synced_folder d.to_s, d.to_s, mount_options: ["share", "nosuid", "host_inodes"]
74-
end
75-
end
76-
77-
config.vm.provider "vmware_desktop" do |vm, overrides|
78-
vm.cpus = num_cores
79-
vm.memory = ram_bytes
80-
vm.vmx["usb_xhci.present"] = "TRUE"
81-
vm.vmx["usb.present"] = "TRUE"
82-
vm.vmx["ehci.present"] = "TRUE"
83-
dirs_to_mount.each do |d|
84-
overrides.vm.synced_folder d.to_s, d.to_s
85-
end
86-
vm.gui = true
87-
end
88-
8966
end

apps/microtvm/reference-vm/arduino/base-box/base_box_test.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ microtvm_platform=$1
3333
pytest tests/micro/arduino/test_arduino_workflow.py --microtvm-platforms=${microtvm_platform}
3434

3535
if [ $microtvm_platform == "nano33ble" ]; then
36+
# https://github.com/apache/tvm/issues/8730
3637
echo "NOTE: skipped test_arduino_rpc_server.py on $microtvm_platform -- known failure"
3738
else
3839
pytest tests/micro/arduino/test_arduino_rpc_server.py --microtvm-platforms=${microtvm_platform}

apps/microtvm/reference-vm/base-box-tool.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,7 @@
7575
# in [platform]/base-box/base_box_provision.sh
7676
EXTRA_SCRIPTS = {
7777
"arduino": (),
78-
"zephyr": (
79-
"docker/install/ubuntu_init_zephyr_project.sh",
80-
"docker/install/ubuntu_install_qemu.sh",
81-
),
78+
"zephyr": ("docker/install/ubuntu_init_zephyr_project.sh",),
8279
}
8380

8481
PACKER_FILE_NAME = "packer.json"
@@ -392,7 +389,6 @@ def test_command(args):
392389
microtvm_test_platform["microtvm_platform"] = args.microtvm_platform
393390

394391
providers = args.provider
395-
print(providers)
396392
provider_passed = {p: False for p in providers}
397393

398394
release_test_dir = os.path.join(THIS_DIR, "release-test")

0 commit comments

Comments
 (0)