Skip to content

Commit 6dc54aa

Browse files
author
Sen Yang
authored
[Bugfix] Fix other div zero errors also in rewrite_simplify (#8983)
* fix div zero error in rewrite_simplify * update the style to fix ci error * remove useless code and comment * fix div zero error of mod, floordiv, floormod in rewrite_simplify * rewrite the test case of divison by zero to fix ci error * remove useless tab * retrigger ci * remove useless blank to retrigger ci
1 parent 2711229 commit 6dc54aa

File tree

2 files changed

+18
-1
lines changed

2 files changed

+18
-1
lines changed

src/arith/rewrite_simplify.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -645,6 +645,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const ModNode* op) {
645645
if (truncmod(ramp(b1, c1, lanes), broadcast(c2, lanes)).Match(ret)) {
646646
int64_t c1val = c1.Eval()->value;
647647
int64_t c2val = c2.Eval()->value;
648+
ICHECK(c2val != 0) << "division by zero";
648649
if (c1val % c2val == 0) {
649650
return broadcast(truncmod(b1, c2), lanes).Eval();
650651
}
@@ -724,6 +725,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const FloorDivNode* op) {
724725
if (floordiv(ramp(b1, c1, lanes), broadcast(c2, lanes)).Match(ret)) {
725726
int64_t c1val = c1.Eval()->value;
726727
int64_t c2val = c2.Eval()->value;
728+
ICHECK(c2val != 0) << "division by zero";
727729
if (c1val % c2val == 0) {
728730
return ramp(floordiv(b1, c2), floordiv(c1, c2), lanes).Eval();
729731
}
@@ -852,6 +854,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const FloorModNode* op) {
852854
if (floormod(ramp(b1, c1, lanes), broadcast(c2, lanes)).Match(ret)) {
853855
int64_t c1val = c1.Eval()->value;
854856
int64_t c2val = c2.Eval()->value;
857+
ICHECK(c2val != 0) << "division by zero";
855858
if (c1val % c2val == 0) {
856859
return broadcast(floormod(b1, c2), lanes).Eval();
857860
}

tests/python/unittest/test_arith_rewrite_simplify.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -934,9 +934,23 @@ def test_shift_left_simplify():
934934

935935
def test_div_zero_simplify():
936936
ck = RewriteChecker()
937+
ramp = tvm.tir.Ramp(1, 1, 2)
938+
broadcast = tvm.tir.Broadcast(0, 2)
937939

938940
with pytest.raises(tvm.error.TVMError) as cm:
939-
ck.analyzer.rewrite_simplify(tvm.tir.Div(tvm.tir.Ramp(1, 1, 2), tvm.tir.Broadcast(0, 2)))
941+
ck.analyzer.rewrite_simplify(tvm.tir.Div(ramp, broadcast))
942+
assert "division by zero" in str(cm.execption)
943+
944+
with pytest.raises(tvm.error.TVMError) as cm:
945+
ck.analyzer.rewrite_simplify(tvm.tir.Mod(ramp, broadcast))
946+
assert "division by zero" in str(cm.execption)
947+
948+
with pytest.raises(tvm.error.TVMError) as cm:
949+
ck.analyzer.rewrite_simplify(tvm.tir.FloorDiv(ramp, broadcast))
950+
assert "division by zero" in str(cm.execption)
951+
952+
with pytest.raises(tvm.error.TVMError) as cm:
953+
ck.analyzer.rewrite_simplify(tvm.tir.FloorMod(ramp, broadcast))
940954
assert "division by zero" in str(cm.execption)
941955

942956

0 commit comments

Comments
 (0)