Fixes click functions on server ip addresses in the server table

CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 - Traffic Portal: [#5361](https://github.com/apache/trafficcontrol/issues/5361) - Added the ability to change the name of a topology.
 - Traffic Portal: [#5340](https://github.com/apache/trafficcontrol/issues/5340) - Added the ability to resend a user registration from user screen.
 - Traffic Portal: [#5394](https://github.com/apache/trafficcontrol/issues/5394) - Converts the tenant table to a tenant tree for usability
+- Traffic Portal: [#5317](https://github.com/apache/trafficcontrol/issues/5317) - Clicking IP addresses in the servers table no longer navigates to server details page.
 - Traffic Portal: upgraded delivery service UI tables to use more powerful/performant ag-grid component
 - Traffic Ops: added a feature so that the user can specify `maxRequestHeaderBytes` on a per delivery service basis
 - Traffic Router: log warnings when requests to Traffic Monitor return a 503 status code

traffic_portal/app/src/common/modules/table/servers/TableServersController.js

@@ -25,11 +25,21 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 	SSHCellRenderer.prototype.init = function(params) {
 		this.eGui = document.createElement("A");
 		this.eGui.href = "ssh://" + userModel.user.username + "@" + params.value;
-		this.eGui.setAttribute("target", "_blank");
+		this.eGui.setAttribute("class", "link");
 		this.eGui.textContent = params.value;
 	};
 	SSHCellRenderer.prototype.getGui = function() {return this.eGui;};
 
+	function HTTPSCellRenderer() {}
+	HTTPSCellRenderer.prototype.init = function(params) {
+		this.eGui = document.createElement("A");
+		this.eGui.href = "https://" + params.value;
+		this.eGui.setAttribute("class", "link");
+		this.eGui.setAttribute("target", "_blank");
+		this.eGui.textContent = params.value;
+	};
+	HTTPSCellRenderer.prototype.getGui = function() {return this.eGui;};
+
 	function UpdateCellRenderer() {}
 	UpdateCellRenderer.prototype.init = function(params) {
 		this.eGui = document.createElement("I");
@@ -96,15 +106,13 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 			headerName: "ILO IP Address",
 			field: "iloIpAddress",
 			hide: true,
-			cellRenderer: "sshCellRenderer",
+			cellRenderer: "httpsCellRenderer",
 			onCellClicked: null
 		},
 		{
 			headerName: "ILO IP Gateway",
 			field: "iloIpGateway",
-			hide: true,
-			cellRenderer: "sshCellRenderer",
-			onCellClicked: null
+			hide: true
 		},
 		{
 			headerName: "ILO IP Netmask",
@@ -124,7 +132,9 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 		{
 			headerName: "IPv6 Address",
 			field: "ip6Address",
-			hide: false
+			hide: false,
+			cellRenderer: "sshCellRenderer",
+			onCellClicked: null
 		},
 		{
 			headerName: "IPv6 Gateway",
@@ -141,31 +151,27 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 		{
 			headerName: "Mgmt IP Address",
 			field: "mgmtIpAddress",
-			hide: true
+			hide: true,
+			cellRenderer: "sshCellRenderer",
+			onCellClicked: null
 		},
 		{
 			headerName: "Mgmt IP Gateway",
 			field: "mgmtIpGateway",
 			hide: true,
-			filter: true,
-			cellRenderer: "sshCellRenderer",
-			onCellClicked: null
+			filter: true
 		},
 		{
 			headerName: "Mgmt IP Netmask",
 			field: "mgmtIpNetmask",
 			hide: true,
-			filter: true,
-			cellRenderer: "sshCellRenderer",
-			onCellClicked: null
+			filter: true
 		},
 		{
 			headerName: "IPv4 Gateway",
 			field: "ipGateway",
 			hide: true,
-			filter: true,
-			cellRenderer: "sshCellRenderer",
-			onCellClicked: null
+			filter: true
 		},
 		{
 			headerName: "IPv4 Address",
@@ -290,6 +296,7 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 	/** Options, configuration, data and callbacks for the ag-grid table. */
 	$scope.gridOptions = {
 		components: {
+			httpsCellRenderer: HTTPSCellRenderer,
 			sshCellRenderer: SSHCellRenderer,
 			updateCellRenderer: UpdateCellRenderer
 		},
@@ -352,6 +359,10 @@ var TableServersController = function(tableName, servers, filter, $scope, $state
 			$scope.mouseDownSelectionText = window.getSelection().toString();
 		},
 		onRowClicked: function(params) {
+			if (params.event.target.classList.contains('link')) {
+				// no need to navigate to server detail page
+				return;
+			}
 			const selection = window.getSelection().toString();
 			if(selection === "" || selection === $scope.mouseDownSelectionText) {
 				locationUtils.navigateToPath('/servers/' + params.data.id);