Update SigV4 interceptor to use latest aws sdk version #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2884 +/- ##
============================================
+ Coverage 76.16% 77.87% +1.70%
- Complexity 13170 13578 +408
============================================
Files 1085 1015 -70
Lines 65189 59308 -5881
Branches 7289 6835 -454
============================================
- Hits 49651 46184 -3467
+ Misses 12830 10817 -2013
+ Partials 2708 2307 -401 ☔ View full report in Codecov by Sentry. |
kenhuuu
reviewed
Nov 4, 2024
| private static final String SERVICE_NAME = "service-name"; | ||
| private static final byte[] REQUEST_BODY = "{\"gremlin\":\"2-1\"}".getBytes(StandardCharsets.UTF_8); | ||
| private static final String HOST = "localhost"; | ||
| private static final String URI_WITH_QUERY_PARAMS = "http://" + HOST + ":8182?a=1&b=2"; |
There was a problem hiding this comment.
This is OK for testing, but technically the TinkerPop HTTP API doesn't allow for query params. The /gremlin endpoint only accepts the request as a POST body.
There was a problem hiding this comment.
I added query params here for testing because the original sigv4 code has logic to extract and set the query params - should that be removed?
|
VOTE +1 |
1 similar comment
|
VOTE +1 |
…n.awssdk and removed old dependency on aws-java-sdk-core. Since latest version of SignedRequest has headers that support multiple values for the same header via Map<String,List> I added validation checks that the expected signed headers only have 1 value. Removed jackson dependency from gremlin-console as it is no longer needed.
andreachild
force-pushed
the
achild/master-http-final-sigv4
branch
from
d863209
to
cfd6889
Compare
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SigV4 interceptor to use the latest version of software.amazon.awssdk and removed old dependency on aws-java-sdk-core. Since latest version of SignedRequest has headers that support multiple values for the same header via Map<String,List> I added validation checks that the expected signed headers only have 1 value.