-
Notifications
You must be signed in to change notification settings - Fork 113
feat: generator operator examples for binary and integer #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds generator operator examples for binary and integer data types, refactoring the existing generator operator to be more specific. The changes include renaming the original generator to focus on integer generation and creating a new binary generator operator with corresponding test files.
- Renamed existing generator operator to
GeneratorOperatorIntegerwith updated documentation - Added new
GeneratorOperatorBinaryclass that produces binary data - Created comprehensive test files for both operator types
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| generator_operator_integer.py | Renamed class and added docstring for integer-focused generator |
| generator_operator_binary.py | New binary generator operator implementation |
| test_generator_operator_integer.py | Updated test file with renamed imports and methods |
| test_generator_operator_binary.py | New test file for binary generator operator |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@AnzhiZhang thanks. could you please remove the @ from the first comment (or called PR description)? we use that space for describing the PR changes, and we tag other people using comments after. |
Yicong-Huang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. please go ahead update the wiki to use the integer example.
Done. Is the current text look good? Or I can rephrase it more like a description. |
|
also, please change "related #issue number" to "closes" or "fixes" |
it will be good to update the reason for the change. our discussion should be reflected here so other readers have context. |
It's a related PR, I will use "resolves" instead.
Updated, please have a look and let me know if any further changes are required. |
|
LGTM |
|
Add "example" in the title? It's different from the operators in the system. |
done |
There is an example Python UDF generator referenced from the wiki. However, the example returns a list, which is a binary attribute type. Intuitively, a starter may think the attribute has an integer type, which will cause some confusion.
#3657 updated that example to return integers. From our discussion today, we will remain with the previous binary example and add an integer example for starters.
The name of the binary generator example is updated. Wiki link here needs to be updated, or we can just leave the binary example for the guide.
Resolves #3657