Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: taking db dependencies out of requirements-dev.txt #7605

Merged
merged 4 commits into from
Jun 24, 2019

Conversation

mistercrunch
Copy link
Member

CATEGORY

  • Build / Development Environment

SUMMARY

Py deps mysqlclient and psycopg2 really aren't dev dependencies, they're more optional deps, so the right place for them is extra_requires in our setup.py.

Not a big deal, but mysqlclient has os-level deps and that forces people setting up a dev env to jump through unnecessary hoops

@mistercrunch mistercrunch force-pushed the optional_deps branch 10 times, most recently from 4335ee5 to 6250fb7 Compare June 3, 2019 02:59
setup.py Outdated
],
'presto': ['pyhive[presto]>=0.4.0'],
'gsheets': ['gsheetsdb>=0.1.9'],
'mysql': ['mysqlclient==1.3.13'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to pin these here? Note we may need to have a requirements.in file including the line-e . (and possibly mention of the extra targets) is we want to have a fully pinned environment for testing purposes.

Copy link
Member Author

@mistercrunch mistercrunch Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip-compile doesn't play nicely with extras, there's no way to say give me the descendants on [only] on extra. Related comment in a related PR here: #7372 (comment)

tox.ini Show resolved Hide resolved
setup.py Show resolved Hide resolved
@mistercrunch mistercrunch force-pushed the optional_deps branch 2 times, most recently from 1ab8d37 to b6f5afb Compare June 24, 2019 04:43
@codecov-io
Copy link

codecov-io commented Jun 24, 2019

Codecov Report

Merging #7605 into master will decrease coverage by 0.04%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7605      +/-   ##
==========================================
- Coverage   65.75%   65.71%   -0.05%     
==========================================
  Files         459      459              
  Lines       21980    21980              
  Branches     2415     2415              
==========================================
- Hits        14453    14444       -9     
- Misses       7406     7415       +9     
  Partials      121      121
Impacted Files Coverage Δ
superset/db_engines/hive.py 0% <0%> (ø) ⬆️
superset/sql_parse.py 99.2% <100%> (ø) ⬆️
superset/db_engine_specs/mysql.py 93.02% <100%> (ø) ⬆️
superset/db_engine_specs/hive.py 39.42% <0%> (-4.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df4fa2...fc69aa4. Read the comment docs.

@mistercrunch mistercrunch merged commit 859d6e7 into apache:master Jun 24, 2019
@mistercrunch mistercrunch deleted the optional_deps branch June 24, 2019 05:37
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants