-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: taking db dependencies out of requirements-dev.txt #7605
Conversation
4335ee5
to
6250fb7
Compare
setup.py
Outdated
], | ||
'presto': ['pyhive[presto]>=0.4.0'], | ||
'gsheets': ['gsheetsdb>=0.1.9'], | ||
'mysql': ['mysqlclient==1.3.13'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to pin these here? Note we may need to have a requirements.in
file including the line-e .
(and possibly mention of the extra targets) is we want to have a fully pinned environment for testing purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip-compile
doesn't play nicely with extras, there's no way to say give me the descendants on [only] on extra. Related comment in a related PR here: #7372 (comment)
6250fb7
to
4ead007
Compare
The deps on mysqlclient and psycopg2
1ab8d37
to
b6f5afb
Compare
b6f5afb
to
fc69aa4
Compare
Codecov Report
@@ Coverage Diff @@
## master #7605 +/- ##
==========================================
- Coverage 65.75% 65.71% -0.05%
==========================================
Files 459 459
Lines 21980 21980
Branches 2415 2415
==========================================
- Hits 14453 14444 -9
- Misses 7406 7415 +9
Partials 121 121
Continue to review full report at Codecov.
|
CATEGORY
SUMMARY
Py deps
mysqlclient
andpsycopg2
really aren't dev dependencies, they're more optional deps, so the right place for them isextra_requires
in oursetup.py
.Not a big deal, but
mysqlclient
has os-level deps and that forces people setting up a dev env to jump through unnecessary hoops