Dashboard Autorefresh Settings Persist #718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the models for Dashboards or Slices (using declarative base)
…ds added to the models for Dashboards or Slices (using declarative base)" This reverts commit 0b6dd69.
|
Coverage increased (+0.02%) to 81.059% when pulling 17d56b5a11152b0e8168bf3c240033327aa65558 on alanmcruickshank:autorefresh-dashboard-2 into 8135c24 on airbnb:master. |
|
Coverage increased (+0.02%) to 81.059% when pulling e10b82e49e431b71ed08d47fbf6591c043ed9bea on alanmcruickshank:autorefresh-dashboard-2 into 8135c24 on airbnb:master. |
alanmcruickshank
force-pushed
the
autorefresh-dashboard-2
branch
from
d4cc26b
to
afb040d
Compare
|
Will rebase and resubmit on a tidier branch. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
This was referenced Dec 15, 2021
This was referenced Feb 1, 2022
This was referenced Sep 27, 2022
This was referenced Oct 6, 2022
This was referenced Dec 19, 2023
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to Issue 686
Adds settings to save and persist dashboard refresh interval and also whether to force refreshing from cache or not. Modal on the Dashboard is changed to allow any value of seconds rather than only the dropdown values.
Pre-existing dashboards (and the defaults for new dashboards) are that the dashboard will refresh using cached values and that initially it won't refresh (interval = 0).
For the values on a dashboard to actually change you should set the cache to expire on a suitable timescale either at the slice level (or higher up the tree).
Includes a fix to migration 27ae655e4247 so that it now uses declarative base to allow the addition of new columns to the model. (@mistercrunch this continues our discussion from this pull request).