Scripts & instructions to craft official Apache source releases #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
apache-releases
branch
from
4c00e01 to
4a264a2
Compare
mistercrunch
force-pushed
the
apache-releases
branch
from
4a264a2 to
0d615a9
Compare
mistercrunch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7054 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 421 421
Lines 20537 20537
Branches 2247 2247
=======================================
Hits 13240 13240
Misses 7170 7170
Partials 127 127
Continue to review full report at Codecov.
|
kristw
reviewed
Mar 19, 2019
INSTALL.txt
Outdated
| npm ci | ||
|
|
||
| # Build the Javascript bundles | ||
| npm run prod |
There was a problem hiding this comment.
Do we use this or npm run build?
There was a problem hiding this comment.
oh right, npm run build is best I think, altering
kristw
added
the
Apache Software Foundation
mistercrunch
commented
Mar 20, 2019
| # You may want to check that there's nothing your care about here first. | ||
| # Alternatively you could clone the repo into another location as in | ||
| # git clone git@github.com:apache/incubator-superset.git superset-releases | ||
| git clean -fxd |
There was a problem hiding this comment.
This is pretty destructive but somewhat required BTW. May issue is if you have a virtualenv it'll erase it.
Was thinking that either we suggest the user to do this in a dedicated repo copy, or we automate it inside a docker container.
kristw
approved these changes
Mar 25, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered markdown here:
https://github.com/mistercrunch/superset/blob/apache-releases/RELEASING.md#apache-releases