[ci] take #2, improve build times by saving TerserPlugin cache #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with the previous solution was that the `npm ci` command nuke the `node_modules` folder, including the `.cache` that was used by default. By moving the cache out of `node_modules` we get to both run `npm ci` and accelerate `TerserPlugin`
Codecov Report
@@ Coverage Diff @@
## master #6882 +/- ##
=======================================
Coverage 63.73% 63.73%
=======================================
Files 419 419
Lines 20482 20482
Branches 2233 2233
=======================================
Hits 13055 13055
Misses 7293 7293
Partials 134 134Continue to review full report at Codecov.
|
kristw
approved these changes
Feb 15, 2019
|
LGTM! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the previous solution was that the
npm cicommandnuke the
node_modulesfolder, including the.cachethat was used bydefault. By moving the cache out of
node_moduleswe get to both runnpm ciand accelerateTerserPluginLooks like it works now, shaves ~5 minutes of the 4 longest items in the matrix
before
after