Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Basic Auth for Druid (Issue #4776) #6795

Merged
merged 6 commits into from
Mar 25, 2019

Conversation

donbowman
Copy link
Contributor

This should resolve Issue #4776

Add HTTP Basic Auth to the Druid Broker.

Screenshot of change:
druid-auth

Signed-off-by: Don Bowman don@agilicus.com

This should resolve [Issue apache#4776](apache#4776)

Add HTTP Basic Auth to the Druid Broker.

Signed-off-by: Don Bowman <don@agilicus.com>
@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #6795 into master will increase coverage by 1.49%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6795      +/-   ##
==========================================
+ Coverage   63.84%   65.33%   +1.49%     
==========================================
  Files         421      422       +1     
  Lines       20445    21455    +1010     
  Branches     2218     2314      +96     
==========================================
+ Hits        13053    14018     +965     
- Misses       7260     7308      +48     
+ Partials      132      129       -3
Impacted Files Coverage Δ
superset/connectors/druid/views.py 66.21% <ø> (-1.37%) ⬇️
superset/connectors/druid/models.py 82.51% <44.44%> (-0.21%) ⬇️
superset/common/query_context.py 22.4% <0%> (-67.6%) ⬇️
superset/common/query_object.py 28.26% <0%> (-66.98%) ⬇️
superset/views/api.py 68.57% <0%> (-20.91%) ⬇️
...rset/assets/src/explore/reducers/exploreReducer.js 35.71% <0%> (-12.57%) ⬇️
...erset/assets/src/dashboard/reducers/datasources.js 57.14% <0%> (-9.53%) ⬇️
...rc/dashboard/components/dnd/dragDroppableConfig.js 29.16% <0%> (-5.84%) ⬇️
...ts/src/dashboard/components/gridComponents/Tab.jsx 66.66% <0%> (-5.75%) ⬇️
...src/explore/components/controls/MetricsControl.jsx 67.58% <0%> (-5.55%) ⬇️
... and 135 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f42ed...871c73b. Read the comment docs.

@donbowman donbowman changed the title [WIP] Add HTTP Basic Auth for Druid (Issue #4776) Add HTTP Basic Auth for Druid (Issue #4776) Jan 31, 2019
@donbowman
Copy link
Contributor Author

The other piece of this is in druid-io/pydruid#149 (for PyDruid SQL mode)

superset/connectors/druid/models.py Outdated Show resolved Hide resolved
Signed-off-by: Don Bowman <don@agilicus.com>
@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community .security labels Feb 7, 2019
@donbowman
Copy link
Contributor Author

are there any additional changes needed?

@donbowman
Copy link
Contributor Author

is there anything else needed here?

@mistercrunch mistercrunch added the risk:db-migration PRs that require a DB migration label Mar 12, 2019
superset/connectors/druid/models.py Outdated Show resolved Hide resolved
@donbowman
Copy link
Contributor Author

I don't really see how this travis failure (ERROR:root:Metric 'sum__SP_RUR_TOTL' is not valid) could relate to the additional tool-tip on these two fields.

@donbowman donbowman closed this Mar 25, 2019
@donbowman donbowman reopened this Mar 25, 2019
@mistercrunch mistercrunch merged commit 4c5e6ca into apache:master Mar 25, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community risk:db-migration PRs that require a DB migration 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Druid] Superset not working with Druid when 'Druid Basic Security' is activated
4 participants