Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py ASF issues #6677

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Fix setup.py ASF issues #6677

merged 1 commit into from
Jan 19, 2019

Conversation

bolkedebruin
Copy link
Contributor

  • This renames the package to apache-superset instead of superset.
    This is required.
  • It sets the download location to the official ASF repositories

@mistercrunch @kristw

@codecov-io
Copy link

codecov-io commented Jan 13, 2019

Codecov Report

Merging #6677 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #6677     +/-   ##
=========================================
+ Coverage   56.14%   56.24%   +0.1%     
=========================================
  Files         521      519      -2     
  Lines       23179    23088     -91     
  Branches     2769     2756     -13     
=========================================
- Hits        13014    12986     -28     
+ Misses       9756     9693     -63     
  Partials      409      409
Impacted Files Coverage Δ
superset/assets/src/components/AsyncSelect.jsx 92.85% <0%> (-3.44%) ⬇️
superset/assets/src/addSlice/AddSliceContainer.jsx 70.83% <0%> (-1.9%) ⬇️
superset/views/datasource.py 93.1% <0%> (-1.35%) ⬇️
superset/data/country_map.py 27.58% <0%> (-0.54%) ⬇️
superset/connectors/druid/models.py 82.37% <0%> (-0.35%) ⬇️
superset/connectors/sqla/models.py 77.92% <0%> (-0.17%) ⬇️
superset/views/sql_lab.py 93.61% <0%> (-0.14%) ⬇️
superset/data/helpers.py 96.42% <0%> (-0.13%) ⬇️
superset/assets/src/components/EditableTitle.jsx 77.04% <0%> (-0.1%) ⬇️
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø) ⬆️
... and 501 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01063ce...c588cdf. Read the comment docs.

@kristw kristw requested a review from mistercrunch January 14, 2019 18:51
@bolkedebruin
Copy link
Contributor Author

ping @mistercrunch

@hughhhh
Copy link
Member

hughhhh commented Jan 16, 2019

@bolkedebruin can you rebase?

@kristw kristw added need:rebase Requires rebasing on top of current master Apache Software Foundation Related to Apache Software Foundation labels Jan 16, 2019
@mistercrunch
Copy link
Member

LGTM

@bolkedebruin
Copy link
Contributor Author

@kristw build failures were unrelated. Can this be merged?

@mistercrunch
Copy link
Member

We actually cannot merge if CI doesn't pass :( We'd have to ask Apache infra to change the Github settings, but unclear if we want to allow this. Mind rebasing?

@kristw
Copy link
Contributor

kristw commented Jan 18, 2019

@mistercrunch Master CI breaks again. Something is strange with all CI that involves python.

@bolkedebruin
Copy link
Contributor Author

Oh I like that actually ;-). Sure I can rebase. I’ll do that ASAP.

@bolkedebruin
Copy link
Contributor Author

But probably you can merge from the command line. I don’t think github will interfere then

@mistercrunch
Copy link
Member

We use Github's protected branch feature on master, can't push to it...

* This renames the package to apache-superset instead of superset.
  This is required.
* It sets the download location to the official ASF repositories
@bolkedebruin
Copy link
Contributor Author

@mistercrunch done.

@kristw kristw merged commit 3cc7cdf into apache:master Jan 19, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apache Software Foundation Related to Apache Software Foundation 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:rebase Requires rebasing on top of current master 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants