-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setup.py ASF issues #6677
Fix setup.py ASF issues #6677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6677 +/- ##
=========================================
+ Coverage 56.14% 56.24% +0.1%
=========================================
Files 521 519 -2
Lines 23179 23088 -91
Branches 2769 2756 -13
=========================================
- Hits 13014 12986 -28
+ Misses 9756 9693 -63
Partials 409 409
Continue to review full report at Codecov.
|
ping @mistercrunch |
@bolkedebruin can you rebase? |
bd5458f
to
3f39dde
Compare
LGTM |
@kristw build failures were unrelated. Can this be merged? |
We actually cannot merge if CI doesn't pass :( We'd have to ask Apache infra to change the Github settings, but unclear if we want to allow this. Mind rebasing? |
@mistercrunch Master CI breaks again. Something is strange with all CI that involves python. |
Oh I like that actually ;-). Sure I can rebase. I’ll do that ASAP. |
But probably you can merge from the command line. I don’t think github will interfere then |
We use Github's protected branch feature on master, can't push to it... |
* This renames the package to apache-superset instead of superset. This is required. * It sets the download location to the official ASF repositories
3f39dde
to
c588cdf
Compare
@mistercrunch done. |
This is required.
@mistercrunch @kristw