Increase size of column name in table ab_view_meu
#6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
added
!deprecated-label:bug
Codecov Report
@@ Coverage Diff @@
## master #6532 +/- ##
=========================================
+ Coverage 73.5% 73.5% +<.01%
=========================================
Files 72 72
Lines 10001 10002 +1
=========================================
+ Hits 7351 7352 +1
Misses 2650 2650
Continue to review full report at Codecov.
|
|
Ping @mistercrunch |
|
LGTM |
phoenix24
approved these changes
Dec 18, 2018
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Dec 19, 2018
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Create migration script * Use batch operation for ALTER COLUMN
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Dec 28, 2018
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
|
@betodealmeida when I do |
mistercrunch
added
the
risk:may-require-downtime
|
@aboganas I also had problems when deploying this, but it eventually went through after I killed some processes in MySQL. I assumed in my case it was taking too long because of the size of the table. I tested on a clean install and it works fine. @mistercrunch any idea why this could be hanging? |
|
There's another script that runs a similar command (https://github.com/apache/incubator-superset/blob/46c86672c8320c0003c2eb26f73db6daa2767996/superset/migrations/versions/956a063c52b3_adjusting_key_length.py#L18). |
|
I left it running and it went through after like 8 hours. so maybe as you said there was a process holding it up |
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 11, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 12, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 14, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 17, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 24, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
xtinec
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 28, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
* Create migration script * Use batch operation for ALTER COLUMN (cherry picked from commit e2b9625)
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 30, 2019
betodealmeida
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jan 31, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5915 introduced support for Google Spreadsheets as datasources, using the
gsheetsdbmodule. The code was tested using only SQLite as Superset's database. Today I discovered it fails in MySQL (and probably other databases that enforce column sizes for strings), since the table name of a Google spreadsheet is too big to be stored in theab_view_menutable.I increased the size of the column
namefrom 100 to 255 characters, and tested the Google connector using MySQL as the main database for Superset.