Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Open control with Simple tab selected when there is no column selected #30502

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes the behavior when opening a column-related Explore control and no column was selected. Previously, if the dataset had any saved column, the Saved tab would be the default selected tab. This created a lot of confusion for our users as generally the number of saved columns is significantly smaller than the number of dataset columns. Also, the users are generally looking for the normal dataset columns and didn't notice that they had to switch to the Simple tab to find them. With this PR, the behavior will be:

  • If there's no selected column, the Simple tab will be selected by default
  • If there is a selected column, the tab that corresponds to its type will be selected by default

I also added tests for each use case.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-10-02.at.13.45.37.mov
Screen.Recording.2024-10-02.at.13.58.47.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch and removed size/L labels Oct 2, 2024
@dosubot dosubot bot added the explore:control Related to the controls panel of Explore label Oct 2, 2024
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina self-assigned this Oct 3, 2024
@michael-s-molina michael-s-molina merged commit 03146b2 into apache:master Oct 3, 2024
36 of 37 checks passed
michael-s-molina added a commit that referenced this pull request Oct 3, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 3, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
No open projects
Status: Cherried
Development

Successfully merging this pull request may close these issues.

2 participants