fix: Open control with Simple tab selected when there is no column selected #30502
+93
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes the behavior when opening a column-related Explore control and no column was selected. Previously, if the dataset had any saved column, the Saved tab would be the default selected tab. This created a lot of confusion for our users as generally the number of saved columns is significantly smaller than the number of dataset columns. Also, the users are generally looking for the normal dataset columns and didn't notice that they had to switch to the
Simple
tab to find them. With this PR, the behavior will be:I also added tests for each use case.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-10-02.at.13.45.37.mov
Screen.Recording.2024-10-02.at.13.58.47.mov
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION