feat(SQL Lab): better SQL parsing error messages #30501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR introduces a new component for showing SQL parsing errors in SQL Lab (based on the exception raised by
sqlglot
), and also improves the<ErrorMessageWithStackTrace/>
to show multiple error messages.In the example below, there is an error parsing the query. When DML is enabled in the database Superset will run a query even if it can't parse it, but when it's disabled it raises an error. With the modifications, the user will see two error messages:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION