Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate _process_sql_expression #30213

Merged
merged 1 commit into from
Sep 10, 2024
Merged

chore: remove duplicate _process_sql_expression #30213

merged 1 commit into from
Sep 10, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Removing some more duplicate logic.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:backend Requires changing the backend label Sep 10, 2024
@betodealmeida betodealmeida force-pushed the remove-duplicate-_process_sql_expression branch from 8dc179e to 307084a Compare September 10, 2024 15:44
@betodealmeida betodealmeida merged commit cddf153 into master Sep 10, 2024
33 checks passed
sadpandajoe pushed a commit that referenced this pull request Sep 12, 2024
@betodealmeida @sadpandajoe
chore: remove duplicate _process_sql_expression (#30213)
4a6dd94 
(cherry picked from commit cddf153)
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 12, 2024
@rusackas rusackas deleted the remove-duplicate-_process_sql_expression branch September 27, 2024 20:54
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend size/M v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betodealmeida @villebro @sadpandajoe