Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adhoc metrics #30202

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: adhoc metrics #30202

merged 2 commits into from
Oct 10, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Rewrite has_table_query to use sqlglot instead of sqlparse.

Part of SIP-117.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

The current tests pass. Also added a regression that was not passing with sqlparse.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:backend Requires changing the backend label Sep 9, 2024
villebro
villebro reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really excited to see this happening! Minor nit + question on some of the removed logic

superset/sql_parse.py Show resolved Hide resolved
superset/sql_parse.py Outdated Show resolved Hide resolved
@betodealmeida betodealmeida changed the title fix: adhoc queries fix: adhoc metrics Sep 10, 2024
@betodealmeida betodealmeida force-pushed the fix-adhoc branch 3 times, most recently from ea598e7 to 559bc02 Compare October 10, 2024 15:12
@betodealmeida betodealmeida force-pushed the fix-adhoc branch 4 times, most recently from 284816b to 6e95c80 Compare October 10, 2024 18:38
@betodealmeida betodealmeida merged commit 0db59b4 into master Oct 10, 2024
33 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 10, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 10, 2024
@betodealmeida @sadpandajoe
fix: adhoc metrics (#30202)
05cccf6 
(cherry picked from commit 0db59b4)
mistercrunch pushed a commit that referenced this pull request Oct 28, 2024
@betodealmeida @mistercrunch
fix: adhoc metrics (#30202)
c2a407e
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro left review comments

@eschutho eschutho eschutho approved these changes

Assignees

@betodealmeida betodealmeida

Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend preset-io size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
No open projects
Apache Superset 4.1
Status: Cherried
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @eschutho @villebro @sadpandajoe