Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard list row height does not match other lists #30025

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the dashboard list row height to match the height of other lists. This problem was introduced by the Slack Avatar integration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

As we can see the row height is not the same between the dashboard and charts list which makes the avatars close to the row separator in the dashboard list.

Screenshot 2024-08-27 at 11 20 21 Screenshot 2024-08-27 at 11 20 35


After the fix, the dashboard list matches the layout of charts/datasets lists and there's a space between the avatars and row separators.

Screenshot 2024-08-27 at 11 21 47

TESTING INSTRUCTIONS

Check that the layout match between lists.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Aug 27, 2024
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The less custom CSS the better - we should probably enforce a [soft] rule to keep css only in the component library / reusable components

@michael-s-molina michael-s-molina merged commit 2afb66d into apache:master Aug 27, 2024
37 checks passed
sadpandajoe pushed a commit that referenced this pull request Aug 27, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 3, 2024
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants