Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Allow auto pruning of the query table #29936

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Enhance the Celery configuration to allow auto pruning of the query table. By default, no pruning is executed but admins now have the option to configure a schedule and retention period in days for the table's records.

TESTING INSTRUCTIONS

1 - Add the required configuration
2 - Check the job execution

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:backend Requires changing the backend sqllab Namespace | Anything related to the SQL Lab labels Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 34.88372% with 28 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (76d897e) to head (752fbb7).
Report is 966 commits behind head on master.

Files with missing lines Patch % Lines
superset/commands/sql_lab/query.py 35.29% 22 Missing ⚠️
superset/tasks/scheduler.py 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29936       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38148    -38088     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31910    -14204     
+ Misses      28017     6238    -21779     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.95% <34.88%> (-0.22%) ⬇️
javascript ?
mysql 76.64% <34.88%> (?)
postgres 76.74% <34.88%> (?)
presto 53.48% <34.88%> (-0.32%) ⬇️
python 83.64% <34.88%> (+20.15%) ⬆️
sqlite 76.22% <34.88%> (?)
unit 60.31% <0.00%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 13, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 15, 2024
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit bac61fc into apache:master Aug 19, 2024
37 checks passed
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend size/L sqllab Namespace | Anything related to the SQL Lab v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants