fix: pass slack recipients correctly #29721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
logging
eschutho
force-pushed
the
elizabeth/slack-logs
branch
from
d58780e
to
9cdf36c
Compare
sadpandajoe
approved these changes
Jul 26, 2024
eschutho
changed the title
sadpandajoe
approved these changes
Jul 26, 2024
eschutho
force-pushed
the
elizabeth/slack-logs
branch
2 times, most recently
from
ab825c8
to
d24bddc
Compare
michael-s-molina
requested review from
michael-s-molina,
betodealmeida and
geido
eschutho
force-pushed
the
elizabeth/slack-logs
branch
from
d24bddc
to
89b3b99
Compare
3 tasks
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
eschutho
force-pushed
the
elizabeth/slack-logs
branch
2 times, most recently
from
b6ceefc
to
338ed7a
Compare
eschutho
force-pushed
the
elizabeth/slack-logs
branch
5 times, most recently
from
a2885ee
to
991aa53
Compare
eschutho
commented
Aug 1, 2024
| @@ -230,6 +230,7 @@ module = "tests.*" | |||
| check_untyped_defs = false | |||
| disallow_untyped_calls = false | |||
| disallow_untyped_defs = false | |||
| disable_error_code = "annotation-unchecked" | |||
There was a problem hiding this comment.
This was needed to skip the error: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked] It seems like it should be covered in check_untyped_defs = false but it is not.
eschutho
commented
Aug 1, 2024
| @@ -53,6 +53,9 @@ function test_init() { | |||
| echo Superset init | |||
| echo -------------------- | |||
| superset init | |||
| echo Load test users | |||
| echo -------------------- | |||
| superset load-test-users | |||
There was a problem hiding this comment.
small fix after an earlier refactor where the test script stopped loading test users.
eschutho
force-pushed
the
elizabeth/slack-logs
branch
from
991aa53
to
429c8b2
Compare
|
Nice! I see some new tests in there too. |
betodealmeida
approved these changes
Aug 2, 2024
WanjohiWanjohi
pushed a commit
to IDinsight/surveystream_superset_source
that referenced
this pull request
Aug 6, 2024
sadpandajoe
pushed a commit
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 57e8cd2)
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There was a bug where the slack recipients weren't getting updated correctly when they changed from v1 name to v2 ids during execution. This also adds slack channels to header logs so that if there is an error of channel_not_found for example, we can check the logs to see which channels were passed in. And lastly I found that the integration tests weren't loading user data, so I fixed that as well.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run a test with slack and check that logs include this new information.
ADDITIONAL INFORMATION