-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate tox in favor of act #29382
base: master
Are you sure you want to change the base?
Conversation
requirements/development.txt
Outdated
@@ -6,16 +6,16 @@ | |||
# pip-compile-multi | |||
# | |||
-r base.txt | |||
-e file:. | |||
-e file:///Users/max/code/superset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-e file:///Users/max/code/superset | |
-e file:. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah that's a pip-compile-multi
bug AFACT, it shows randomly every 2-4 runs for me... Not sure if it's been reported.
Interesting, I tried this a few years ago iIRC, and it was horribly buggy. Will take it for a new spin.. |
Same, I tried using it in 2020 and it was unusable! It'll be good to have a way of running the CI locally, assuming the runs are representative. |
Same, I could never get |
Let me try and make sure most workflows that someone might want to run locally actually runs through. |
@rusackas seems like --secret and --container-architecture fixed a lot of things for me, not sure how much you pushed but I have to admit I haven't tried anywhere close to all the workflows yet. Actually many of the workflows don't make sense to run locally... act --job {workflow_name} --secret GITHUB_TOKEN=$GITHUB_TOKEN --event pull_request --container-architecture linux/amd64 |
As we discussed on Zoom, I'm still having a hard time getting any of this to work...
Hopefully there's a way to at least get around the first issue by pointing it to the workflow files(s) it should pay attention to. I'll do a little reading and see if I get lucky. |
changing my Reinstalling node modules in |
Realizing there's significantly much more work to do here. Last time I pushed this forward I found some clear incompatibility between the base Ubuntu images used by github and the ones used by |
Thinking about the success criteria for this PR, seems
|
Should we move this back to |
Yup, also would welcome some help here as I got tangled up in other things and it looks like this is getting pushed to the bottom of my todo list now. Things seem super promising, but there's quite a few little things to connect. I discovered there's support for The last blocker I had was around the |
45fe467
to
4ec6610
Compare
Set up
act
as a mean to run GitHub Actions locally as an alternative totox
.tox
act