Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures #24029

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented May 11, 2023

SUMMARY

This PR addresses Superset 3.0 task #45.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--update-mutator-logger-signature branch 2 times, most recently from 63d509b to 211cc0c Compare May 11, 2023 21:54
@john-bodley john-bodley marked this pull request as ready for review May 16, 2023 05:45
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #24029 (c7be3d5) into master (e856e35) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c7be3d5 differs from pull request most recent head 86eaed5. Consider uploading reports for the commit 86eaed5 to get more accurate results

@@            Coverage Diff             @@
##           master   #24029      +/-   ##
==========================================
- Coverage   68.30%   68.30%   -0.01%     
==========================================
  Files        1952     1952              
  Lines       75432    75431       -1     
  Branches     8191     8191              
==========================================
- Hits        51521    51520       -1     
  Misses      21807    21807              
  Partials     2104     2104              
Flag Coverage Δ
hive 53.17% <100.00%> (-0.01%) ⬇️
mysql 78.94% <100.00%> (-0.01%) ⬇️
postgres 79.01% <100.00%> (-0.01%) ⬇️
presto 53.09% <100.00%> (-0.01%) ⬇️
python 82.81% <100.00%> (-0.01%) ⬇️
sqlite 77.54% <100.00%> (-0.01%) ⬇️
unit 53.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 92.02% <ø> (ø)
superset/models/core.py 89.95% <ø> (-0.03%) ⬇️
superset/models/helpers.py 69.83% <ø> (ø)
superset/sql_lab.py 86.41% <ø> (ø)
superset/connectors/sqla/models.py 89.77% <100.00%> (ø)
superset/db_engine_specs/base.py 90.82% <100.00%> (ø)
superset/sql_validators/presto_db.py 82.43% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup @john-bodley. I left a comment but other then that LGTM.

UPDATING.md Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version.

## Next

- [24029](https://github.com/apache/superset/pull/24029) Removes the `user` and `username` arguments for the QUERY_LOGGER and SQL_QUERY_MUTATOR methods respectively. If the username for the current user is required the `superset.utils.core.get_username` method should be used.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the Breaking Changes section?

@john-bodley john-bodley force-pushed the john-bodley--update-mutator-logger-signature branch from 7f39800 to d97b776 Compare May 17, 2023 16:13
@john-bodley john-bodley force-pushed the john-bodley--update-mutator-logger-signature branch from fab5ad7 to 86eaed5 Compare May 18, 2023 23:33
@john-bodley john-bodley merged commit 0496779 into apache:master May 19, 2023
@john-bodley john-bodley deleted the john-bodley--update-mutator-logger-signature branch May 19, 2023 13:42
@eschutho eschutho added the risk:breaking-change Issues or PRs that will introduce breaking changes label Jun 2, 2023
@eschutho
Copy link
Member

eschutho commented Jun 2, 2023

@john-bodley I'm just tagging this with risk:breaking-change for anyone that might be overriding the config.

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 5, 2023
@eschutho
Copy link
Member

eschutho commented Jun 5, 2023

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

@michael-s-molina
Copy link
Member

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

Definitely. I think there was a miscommunication in the review because there's breaking change text added in this PR but it seems it's not related to the particular change.

@michael-s-molina
Copy link
Member

michael-s-molina commented Jun 5, 2023

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

@eschutho @john-bodley I added the breaking change text here.

michael-s-molina added a commit to michael-s-molina/superset that referenced this pull request Jun 5, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
Sopholos added a commit to Sopholos/ansible_role_superset that referenced this pull request Nov 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants