fix(sankey): Return the exact faulty link instead of root

[nottatdat]

SUMMARY

The current implementation returns the root of the faulty branch in the tree

if neighbour in path or visit(neighbour):
    return (vertex, neighbour)

The goal of this PR is to pinpoint the exact faulty link in the tree.

cycle = (vertex, neighbour) if neighbour in path else visit(neighbour)
if cycle:
    return cycle

[github-actions]

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

[rusackas]

@nottatdat can you give us a way to test this, or screenshots of whatever's broken? I'm assuming this is still an issue in Superset 3.x? Meanwhile, closing/reopening to see if we can get it to pass CI.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.02%. Comparing base (7ef06b0) to head (cab4668).
Report is 2857 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #23444      +/-   ##
==========================================
+ Coverage   65.76%   68.02%   +2.26%     
==========================================
  Files        1908     1909       +1     
  Lines       73726    73906     +180     
  Branches     7989     7989              
==========================================
+ Hits        48489    50278    +1789     
+ Misses      23189    21580    -1609     
  Partials     2048     2048              

Flag	Coverage Δ
hive	53.81% <0.00%> (?)
mysql	78.04% <100.00%> (?)
postgres	78.14% <100.00%> (-0.37%)	⬇️
presto	53.76% <0.00%> (?)
python	83.10% <100.00%> (+4.59%)	⬆️
sqlite	77.66% <100.00%> (?)
unit	56.49% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

LGTM. Pre-commit seems to be having issues... I'll close/reopen to kick-start CI.

[rusackas]

Looks like you just need to run the pre-commit hooks to fix this up (or let me push to your branch). To install the hook, run the following:

pip3 install -r requirements/development.txt
pre-commit install
A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files