-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated ETagResponseMixin #21773
fix: remove deprecated ETagResponseMixin #21773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21773 +/- ##
===========================================
- Coverage 66.88% 55.50% -11.38%
===========================================
Files 1802 1802
Lines 68987 68987
Branches 7345 7345
===========================================
- Hits 46139 38291 -7848
- Misses 20951 28799 +7848
Partials 1897 1897
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixing, LGTM.
(cherry picked from commit 75e6a04)
(cherry picked from commit 75e6a04)
SUMMARY
The Werkzeug 2.1 release removed some deprecated code and merged the ETagResponseMixin into the Response class. Instead of pinning superset to any flask or werkzeug version, I'm returning the Response object here instead of the mixin so that we can continue to support later versions. This seems to be an issue commonly found in Ubuntu systems.
ADDITIONAL INFORMATION