Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: database schema selector on import data #21759

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Small refactor on CSV, Excel, Columnar database data import. Make javascript reusable

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #21759 (852c553) into master (d1a6f0e) will decrease coverage by 0.74%.
The diff coverage is 72.72%.

❗ Current head 852c553 differs from pull request most recent head 956ad44. Consider uploading reports for the commit 956ad44 to get more accurate results

@@            Coverage Diff             @@
##           master   #21759      +/-   ##
==========================================
- Coverage   66.85%   66.10%   -0.75%     
==========================================
  Files        1800     1800              
  Lines       68957    68957              
  Branches     7335     7335              
==========================================
- Hits        46098    45582     -516     
- Misses      20966    21482     +516     
  Partials     1893     1893              
Flag Coverage Δ
hive 52.93% <ø> (ø)
mysql ?
postgres ?
presto 52.83% <ø> (ø)
python 79.91% <ø> (-1.55%) ⬇️
sqlite 76.80% <ø> (ø)
unit 51.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
...ackages/superset-ui-switchboard/src/switchboard.ts 100.00% <100.00%> (ø)
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 31.25% <0.00%> (-68.75%) ⬇️
superset/datasets/commands/bulk_delete.py 33.33% <0.00%> (-53.34%) ⬇️
superset/datasets/columns/commands/delete.py 44.11% <0.00%> (-52.95%) ⬇️
superset/datasets/metrics/commands/delete.py 44.11% <0.00%> (-52.95%) ⬇️
superset/datasets/dao.py 44.21% <0.00%> (-50.35%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/datasets/commands/delete.py 48.57% <0.00%> (-48.58%) ⬇️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 91f0de0 into apache:master Oct 10, 2022
@dpgaspar dpgaspar deleted the fix/database-schema-selector branch October 10, 2022 16:56
@dpgaspar dpgaspar added the v2.0 label Oct 26, 2022
@AAfghahi AAfghahi added the v2.0.1 label Nov 1, 2022
AAfghahi pushed a commit that referenced this pull request Nov 1, 2022
eschutho pushed a commit that referenced this pull request Nov 2, 2022
AAfghahi pushed a commit that referenced this pull request Nov 18, 2022
AAfghahi pushed a commit that referenced this pull request Dec 15, 2022
michael-s-molina pushed a commit that referenced this pull request Jan 5, 2023
@mistercrunch mistercrunch added 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L v1.5 v2.0 v2.0.1 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants