fix: dashboard filter value is cleared when 2 similar dashboards opened in succession

[mayurnewase]

SUMMARY

fixes: #21353

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: check the issue description

After:
Screencast from 14-09-22 08:36:50 AM IST.webm

TESTING INSTRUCTIONS

1. open 1 dashboard add 1 native filter of type value on any column and set any default value and save it
2. save that dashboard by overwriting itself.
3. save it again creating a new copy
4. change the default value for that filter to something else
5. save this dashboard by overwriting itself.
6. now go to dashboard list
7. open original dashboard
8. should apply default value of its filter

ADDITIONAL INFORMATION

• Has associated issue: Dashboard filter default value is cleared when 2 dashboards (one cloned from another) opened in succession having filters on same column name of same type #21353
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21461 (420034e) into master (9c285da) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21461      +/-   ##
==========================================
+ Coverage   66.53%   66.56%   +0.02%     
==========================================
  Files        1791     1791              
  Lines       68599    68617      +18     
  Branches     7320     7319       -1     
==========================================
+ Hits        45645    45675      +30     
+ Misses      21064    21043      -21     
- Partials     1890     1899       +9     

Flag	Coverage Δ
javascript	52.80% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...board/components/nativeFilters/FilterBar/index.tsx	66.18% <100.00%> (+6.04%)	⬆️
...iews/CRUD/data/dataset/AddDataset/Header/index.tsx	87.50% <0.00%> (-12.50%)	⬇️
...ontend/src/explore/controlUtils/getControlState.ts	80.32% <0.00%> (-10.42%)	⬇️
superset-frontend/src/views/CRUD/utils.tsx	64.28% <0.00%> (-0.52%)	⬇️
superset-frontend/src/components/Tooltip/index.tsx	100.00% <0.00%> (ø)
...set-frontend/src/views/CRUD/data/dataset/styles.ts	100.00% <0.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx	76.00% <0.00%> (ø)
...frontend/src/components/DatabaseSelector/index.tsx	95.23% <0.00%> (ø)
...end/src/components/PageHeaderWithActions/index.tsx	90.00% <0.00%> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts	100.00% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM. Thanks for the fix.

[mayurnewase]

don't know how to add test for this.