Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cached common bootstrap Revert (#21018) #21419

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 9, 2022

SUMMARY

Fixes common bootstrap data context issue.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching the bug!

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #21419 (ee2d3bd) into master (d3f9fbb) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21419      +/-   ##
==========================================
- Coverage   66.57%   66.57%   -0.01%     
==========================================
  Files        1791     1791              
  Lines       68593    68591       -2     
  Branches     7319     7319              
==========================================
- Hits        45665    45663       -2     
  Misses      21031    21031              
  Partials     1897     1897              
Flag Coverage Δ
hive 52.93% <ø> (-0.01%) ⬇️
mysql 80.77% <ø> (-0.01%) ⬇️
postgres 80.82% <ø> (-0.01%) ⬇️
presto 52.83% <ø> (-0.01%) ⬇️
python 81.29% <ø> (-0.01%) ⬇️
sqlite 79.37% <ø> (-0.01%) ⬇️
unit 50.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 75.44% <ø> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar merged commit 094400c into apache:master Sep 10, 2022
@dpgaspar dpgaspar deleted the fix/revert-bootstrap-cache branch September 10, 2022 00:02
@dpgaspar dpgaspar added the v2.0 label Sep 10, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Sep 12, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.35

michael-s-molina pushed a commit that referenced this pull request Sep 14, 2022
eschutho pushed a commit that referenced this pull request Sep 20, 2022
AAfghahi pushed a commit that referenced this pull request Oct 6, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants