-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-echarts): show zero value in tooltip #21296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #21296 +/- ##
==========================================
- Coverage 66.43% 66.42% -0.02%
==========================================
Files 1784 1784
Lines 68185 68185
Branches 7265 7264 -1
==========================================
- Hits 45298 45291 -7
- Misses 21018 21024 +6
- Partials 1869 1870 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com> (cherry picked from commit 1aeb8fd)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com> (cherry picked from commit 1aeb8fd)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com> (cherry picked from commit 1aeb8fd)
SUMMARY
Currently only truthy values are shown on the tooltip of the ECharts plugin, causing zeros to be removed.
The PR fixes the bug and adds unit tests for both extracting the series and formatting (logic of both have been updated). In addition the tests are refactored to the preferred single test format (the refactoring changes can best be seen with "Hide whitespace changes").
AFTER
Now zero is shown on the tooltip; see the series
SUM(0)
:BEFORE
Previously only truthy values were shown, i.e. excluding zero:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION