-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adds TLS certificate validation option for SMTP #21272
fix: adds TLS certificate validation option for SMTP #21272
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21272 +/- ##
==========================================
- Coverage 66.43% 66.23% -0.20%
==========================================
Files 1784 1784
Lines 68185 68190 +5
Branches 7265 7265
==========================================
- Hits 45298 45166 -132
- Misses 21018 21155 +137
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
(cherry picked from commit 9fd7520)
(cherry picked from commit 9fd7520)
(cherry picked from commit 9fd7520)
SUMMARY
By default python's standard library will not validate SMTP server certificates, more info here:
context: python/cpython#91826
This PR adds a new config key name
SMTP_SSL_SERVER_AUTH
that enforces smtp server certificate validation,using the default system CA certificates.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION