Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds TLS certificate validation option for SMTP #21272

Conversation

dpgaspar
Copy link
Member

SUMMARY

By default python's standard library will not validate SMTP server certificates, more info here:
context: python/cpython#91826

This PR adds a new config key name SMTP_SSL_SERVER_AUTH that enforces smtp server certificate validation,
using the default system CA certificates.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #21272 (4d53b9f) into master (6223042) will decrease coverage by 0.19%.
The diff coverage is 93.75%.

❗ Current head 4d53b9f differs from pull request most recent head 499e1ae. Consider uploading reports for the commit 499e1ae to get more accurate results

@@            Coverage Diff             @@
##           master   #21272      +/-   ##
==========================================
- Coverage   66.43%   66.23%   -0.20%     
==========================================
  Files        1784     1784              
  Lines       68185    68190       +5     
  Branches     7265     7265              
==========================================
- Hits        45298    45166     -132     
- Misses      21018    21155     +137     
  Partials     1869     1869              
Flag Coverage Δ
hive ?
mysql 80.81% <100.00%> (+<0.01%) ⬆️
postgres 80.86% <100.00%> (+<0.01%) ⬆️
presto ?
python 80.92% <100.00%> (-0.42%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/FilterableTable/index.tsx 72.34% <50.00%> (ø)
superset/config.py 91.61% <100.00%> (+0.02%) ⬆️
superset/utils/core.py 90.27% <100.00%> (-0.07%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.09% <0.00%> (-16.02%) ⬇️
superset/db_engine_specs/presto.py 81.32% <0.00%> (-6.63%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 86.36% <0.00%> (-2.28%) ⬇️
superset/models/sql_lab.py 74.90% <0.00%> (-2.00%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar requested a review from eschutho August 31, 2022 17:11
@dpgaspar dpgaspar merged commit 9fd7520 into apache:master Sep 1, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-49115/tls-certificate-verification-with-smtp branch September 1, 2022 09:51
@dpgaspar dpgaspar added the v2.0 label Sep 1, 2022
michael-s-molina pushed a commit that referenced this pull request Sep 6, 2022
@michael-s-molina michael-s-molina changed the title feat: adds TLS certificate validation option for SMTP fix: adds TLS certificate validation option for SMTP Sep 6, 2022
eschutho pushed a commit that referenced this pull request Sep 20, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@michael-s-molina michael-s-molina added v1.5 and removed v1.5 labels Jan 3, 2023
@mistercrunch mistercrunch added 🍒 1.5.2 🍒 1.5.3 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.0 v2.0.1 🍒 1.5.2 🍒 1.5.3 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants