fix(async-queries): make global async. queries cookie SameSite option configurable #21185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
|
Thanks for the fix, and sorry it hasn't gotten more attention. Trying to get it routed on a path to success! |
villebro
reviewed
Jan 14, 2023
superset/config.py
Outdated
| @@ -1282,6 +1282,7 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument | |||
| GLOBAL_ASYNC_QUERIES_REDIS_STREAM_LIMIT_FIREHOSE = 1000000 | |||
| GLOBAL_ASYNC_QUERIES_JWT_COOKIE_NAME = "async-token" | |||
| GLOBAL_ASYNC_QUERIES_JWT_COOKIE_SECURE = False | |||
| GLOBAL_ASYNC_QUERIES_JWT_COOKIE_SAMESITE = None # One of [None, 'None', 'Lax', 'Strict'] | |||
There was a problem hiding this comment.
nit: it's generally convention to add these as type annotations:
Suggested change
| GLOBAL_ASYNC_QUERIES_JWT_COOKIE_SAMESITE = None # One of [None, 'None', 'Lax', 'Strict'] | |
| GLOBAL_ASYNC_QUERIES_JWT_COOKIE_SAMESITE: Optional[Literal['None', 'Lax', 'Strict']] = None |
…al-async-queries-cookie
Codecov Report
@@ Coverage Diff @@
## master #21185 +/- ##
=======================================
Coverage 67.10% 67.11%
=======================================
Files 1869 1869
Lines 71609 71612 +3
Branches 7822 7822
=======================================
+ Hits 48056 48059 +3
Misses 21526 21526
Partials 2027 2027
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
villebro
approved these changes
Jan 16, 2023
rdubois
deleted the
rdubois/fix/21183/define-samesite-for-global-async-queries-cookie
branch
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #21183
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION