Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key error on permalink fetch for old permalinks #20414

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

eschutho
Copy link
Member

SUMMARY

Adds in backward compatibility for old permalink keys that may have datasetId instead of datasourceId

TESTING INSTRUCTIONS

Testing requires an old permalink, so it will be difficult to test on ephemeral. You can do regression testing on ephemeral for new keys by creating and viewing permalinks from explore.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/fix-permalink-error branch from d2c0d5c to d6a3f30 Compare June 16, 2022 18:37
@eschutho eschutho changed the title fix key error on permalink fetch for old permalinks fix: key error on permalink fetch for old permalinks Jun 16, 2022
@eschutho eschutho added the v2.0 label Jun 16, 2022
@eschutho
Copy link
Member Author

Fixes a bug from #19981

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #20414 (69571a1) into master (ead1040) will decrease coverage by 0.04%.
The diff coverage is 90.00%.

❗ Current head 69571a1 differs from pull request most recent head dd3b634. Consider uploading reports for the commit dd3b634 to get more accurate results

@@            Coverage Diff             @@
##           master   #20414      +/-   ##
==========================================
- Coverage   66.69%   66.65%   -0.05%     
==========================================
  Files        1739     1739              
  Lines       65153    65136      -17     
  Branches     6903     6897       -6     
==========================================
- Hits        43453    43415      -38     
- Misses      19947    19968      +21     
  Partials     1753     1753              
Flag Coverage Δ
hive 53.70% <40.00%> (+<0.01%) ⬆️
mysql 82.29% <100.00%> (+<0.01%) ⬆️
postgres 82.36% <100.00%> (+<0.01%) ⬆️
presto ?
python 82.67% <100.00%> (-0.12%) ⬇️
sqlite 82.09% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...art-controls/src/operators/contributionOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <ø> (ø)
...i-chart-controls/src/operators/resampleOperator.ts 100.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (ø)
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 33.33% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 33.33% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead1040...dd3b634. Read the comment docs.

@eschutho eschutho force-pushed the elizabeth/fix-permalink-error branch from d6a3f30 to dd3b634 Compare June 16, 2022 19:00
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eschutho eschutho merged commit 12436e4 into apache:master Jun 16, 2022
michael-s-molina pushed a commit that referenced this pull request Jun 23, 2022
@mistercrunch mistercrunch added 🍒 2.0.0 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants