-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: key error on permalink fetch for old permalinks #20414
fix: key error on permalink fetch for old permalinks #20414
Conversation
d2c0d5c
to
d6a3f30
Compare
Fixes a bug from #19981 |
Codecov Report
@@ Coverage Diff @@
## master #20414 +/- ##
==========================================
- Coverage 66.69% 66.65% -0.05%
==========================================
Files 1739 1739
Lines 65153 65136 -17
Branches 6903 6897 -6
==========================================
- Hits 43453 43415 -38
- Misses 19947 19968 +21
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d6a3f30
to
dd3b634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
(cherry picked from commit 12436e4)
SUMMARY
Adds in backward compatibility for old permalink keys that may have datasetId instead of datasourceId
TESTING INSTRUCTIONS
Testing requires an old permalink, so it will be difficult to test on ephemeral. You can do regression testing on ephemeral for new keys by creating and viewing permalinks from explore.
ADDITIONAL INFORMATION