Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(home): Show home page tabs as pills instead of links #20257

Merged
merged 7 commits into from
Jun 21, 2022
Merged

fix(home): Show home page tabs as pills instead of links #20257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1fdb97c
fix(home): make to update the css style of links
prosdev0107 Jun 3, 2022
8126739
fix(home): make to fix lint issue
prosdev0107 Jun 3, 2022
4ab036d
fix(home): make to remove underline when tab is active
prosdev0107 Jun 10, 2022
d0f6ab9
fix(home): make to merge master
prosdev0107 Jun 10, 2022
98af369
fix(homes): make to fix the issue of tab
prosdev0107 Jun 14, 2022
0834234
fix(home): make to move styles to a tag
prosdev0107 Jun 20, 2022
d1f4922
fix(home): make to merge master
prosdev0107 Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/src/components/Menu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ const MenuItem = styled(AntdMenu.Item)`
}

&.ant-menu-item {
height: ${({ theme }) => theme.gridUnit * 7}px;
line-height: ${({ theme }) => theme.gridUnit * 7}px;
height: ${({ theme }) => theme.gridUnit * 8}px;
line-height: ${({ theme }) => theme.gridUnit * 8}px;
a {
border-bottom: none;
transition: background-color ${({ theme }) => theme.transitionTiming}s;
Expand Down
9 changes: 6 additions & 3 deletions superset-frontend/src/views/components/SubMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ const StyledHeader = styled.div`

a {
margin: 0;
padding: ${({ theme }) => theme.gridUnit * 4}px;
padding: ${({ theme }) => theme.gridUnit * 2}px
${({ theme }) => theme.gridUnit * 4}px;
line-height: ${({ theme }) => theme.gridUnit * 5}px;

&:hover {
Expand All @@ -112,7 +113,8 @@ const StyledHeader = styled.div`
}

&.active a {
text-decoration: underline;
background: ${({ theme }) => theme.colors.secondary.light4};
border-radius: ${({ theme }) => theme.borderRadius}px;
}
}

Expand All @@ -122,7 +124,8 @@ const StyledHeader = styled.div`
li > a:hover,
li > a:focus,
li > div:hover,
div > div:hover {
div > div:hover,
div > a:hover {
background: ${({ theme }) => theme.colors.secondary.light4};
border-bottom: none;
border-radius: ${({ theme }) => theme.borderRadius}px;
Expand Down