Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates release scripts and docs #20231

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 1, 2022

SUMMARY

Removes the logic to automatically send release-related emails. Now, the scripts will only generate the email content and the release manager have to manually send the emails. The objective is to avoid delivering incorrect emails to the dev list which has a big audience. The documentation was also updated with new steps related to the release.

TESTING INSTRUCTIONS

  • Set the environment variables using the set_release_env.sh script
  • Execute the generate_email.py script for each command (vote_pmc, result_pmc, announce)
  • The script should correctly generate the email text for each command

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor (non-blocking) suggestion. Also, I think we could change the prefix in the title to docs, as it's an improvement (not a pure chore).

RELEASING/generate_email.py Show resolved Hide resolved
@michael-s-molina michael-s-molina changed the title chore: Updates release scripts and docs docs: Updates release scripts and docs Jun 2, 2022
@michael-s-molina michael-s-molina merged commit 9045949 into apache:master Jun 2, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* chore: Updates release scripts and docs

* Adds default receiver
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants