-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashbaord unable to refresh #20220
fix: dashbaord unable to refresh #20220
Conversation
9bec08c
to
8e90264
Compare
Codecov Report
@@ Coverage Diff @@
## master #20220 +/- ##
==========================================
- Coverage 54.55% 54.55% -0.01%
==========================================
Files 1727 1727
Lines 64702 64707 +5
Branches 6824 6824
==========================================
+ Hits 35298 35300 +2
- Misses 27672 27674 +2
- Partials 1732 1733 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@stephenLYZ Ephemeral environment spinning up at http://54.202.157.224:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The original PR intends to decouple
updateQueryFormData
and query request, but the Dashboard also depends on this action after query chart data. I revert this change. This change only affects the first time open explore page if results pane opened, the results pane will be waiting forChartStatus
to getrendered
value(this is also the behavior of the original dataTablesPane).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER
refresh.dashboard.mov
Before
before.refresh.mov
TESTING INSTRUCTIONS
refresh dashboard
in the right corner's 3 dots.ADDITIONAL INFORMATION