Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dashbaord unable to refresh #20220

Merged

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented May 30, 2022

SUMMARY

The original PR intends to decouple updateQueryFormData and query request, but the Dashboard also depends on this action after query chart data. I revert this change. This change only affects the first time open explore page if results pane opened, the results pane will be waiting for ChartStatus to get rendered value(this is also the behavior of the original dataTablesPane).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

AFTER

refresh.dashboard.mov

Before

before.refresh.mov

TESTING INSTRUCTIONS

  1. open dashboard
  2. click refresh dashboard in the right corner's 3 dots.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review May 30, 2022 10:14
@zhaoyongjie zhaoyongjie force-pushed the fix/fix_dashboard_unable_fresh branch from 9bec08c to 8e90264 Compare May 30, 2022 10:19
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #20220 (c0b6de0) into master (e140b7a) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #20220      +/-   ##
==========================================
- Coverage   54.55%   54.55%   -0.01%     
==========================================
  Files        1727     1727              
  Lines       64702    64707       +5     
  Branches     6824     6824              
==========================================
+ Hits        35298    35300       +2     
- Misses      27672    27674       +2     
- Partials     1732     1733       +1     
Flag Coverage Δ
javascript 51.33% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/components/Chart/chartAction.js 55.26% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 74.19% <ø> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.02% <ø> (-0.28%) ⬇️
...mponents/DataTablesPane/components/ResultsPane.tsx 58.92% <66.66%> (-7.11%) ⬇️
...plore/components/DataTablesPane/DataTablesPane.tsx 85.71% <100.00%> (+0.42%) ⬆️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.50% <0.00%> (+0.11%) ⬆️
superset-frontend/src/components/Modal/Modal.tsx 86.56% <0.00%> (+0.41%) ⬆️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.36% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e140b7a...c0b6de0. Read the comment docs.

@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

@stephenLYZ Ephemeral environment spinning up at http://54.202.157.224:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 3d5ae62 into apache:master Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants