fix: Fixes issue where results panel height was incorrect [sc-49045] #20204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.
SUMMARY
This PR fixes a dynamic height assignment issue where the SQL Editor results panel would be clipped offscreen and user could not see bottom of results, the height got assigned to zero after toggling online, then offline, and height would be calculated wrong if the result set rows returned message above the results table was long enough for a line wrap.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before Fix:
https://drive.google.com/file/d/1A0mMm-1HoO2ol-65Tv3ENpv1e1tMRg_g/view?usp=sharing
After Fix:
https://drive.google.com/file/d/1Y7GFbvo_hfEsl6hhD1WI6if6m0BA128C/view
TESTING INSTRUCTIONS
1.Open SQL Editor
2.Create new or use existing Query
3. Click "RUN"
4. You should see the results under the SQL Editor
5. In Chrome Developer tools -> Network -> Change network speed from "No throttling" to "Offline"
6. Click "RUN"
7. Wait for UI to show the red "Offline" pill
8. In Chrome Developer tools -> Network -> Change network speed from "Offline" to "No throttling"
9. Click "RUN"
Expected results (with fix)
After re-enabling the network connection and clicking run you should see query results again
Actual results (before fix)
The results panel is hidden with a CSS height of zero and will stay hidden until the browser is refreshed, or the user toggles between open Sql Editor tabs
ADDITIONAL INFORMATION