Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: While exporting CSV , only the entries on first page are getting downloaded even when user is on other pages #17861 #20178

Merged

Conversation

LahmerIlyas
Copy link
Contributor

@LahmerIlyas LahmerIlyas commented May 24, 2022

SUMMARY

Passed ownState property to export as csv api call.

AFTER VIDEO RECORDING

output.mp4

TESTING INSTRUCTIONS

  • Navigate to any table where server side pagination is enabled (test it on both the explore and the dashboard pages)
  • Click on export CSV(both explore and dashboard pages)

ADDITIONAL INFORMATION

  • Has associated issue:17861
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@LahmerIlyas LahmerIlyas force-pushed the fix/export_paginated_table_into_csv branch from 334ff31 to bbbf1cc Compare June 1, 2022 11:59
@pull-request-size pull-request-size bot added size/XS and removed size/M labels Jun 1, 2022
@LahmerIlyas
Copy link
Contributor Author

@geido the CI/CD was failing ,I fixed the issues and rebased on top of the latest updates. Can u approve running the pipeling again

@zhaoyongjie zhaoyongjie self-requested a review June 2, 2022 02:17
@zhaoyongjie
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #20178 (bbbf1cc) into master (1530c34) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20178   +/-   ##
=======================================
  Coverage   66.49%   66.49%           
=======================================
  Files        1726     1726           
  Lines       64756    64756           
  Branches     6826     6826           
=======================================
  Hits        43060    43060           
  Misses      19963    19963           
  Partials     1733     1733           
Flag Coverage Δ
javascript 51.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 60.60% <ø> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 51.35% <ø> (ø)
.../explore/components/ExploreViewContainer/index.jsx 52.84% <ø> (ø)
...mponents/useExploreAdditionalActionsMenu/index.jsx 62.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1530c34...bbbf1cc. Read the comment docs.

@zhaoyongjie
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

@zhaoyongjie Ephemeral environment spinning up at http://35.89.28.38:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! BTW, the props ownState is not a meaningful name, I always forget what it stands for, but it has nothing to do with this PR.

@zhaoyongjie zhaoyongjie merged commit d4f320f into apache:master Jun 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mboujaha
Copy link

I'm still having this issue, any updates ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.0 v2.0.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants