-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied #20173
fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied #20173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20173 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 1721 1721
Lines 64548 64548
Branches 6811 6811
=======================================
Hits 42890 42890
Misses 19925 19925
Partials 1733 1733
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…er when css rule applied
d792183
to
1e8fa65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…er when css rule applied (apache#20173)
SUMMARY
Adding custom CSS to a dashboard with a bigInt chart would activate a while loop that didn't ever finished, which somehow wasn't caught by the surrounding ErrorBoundary cause the whole app crashed before running out of memory (my guess)
Follow up on #20067, adding the missing titles
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
168395532-ef3dc781-3415-4a76-82fa-23d796395bde.1.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION