fix: advanced data type API spec and permission name - #20128
Conversation
villebro
left a comment
There was a problem hiding this comment.
LGTM, thanks for this improvement! FYI @cccs-RyanS
Codecov Report
@@ Coverage Diff @@
## master #20128 +/- ##
==========================================
- Coverage 66.47% 66.28% -0.19%
==========================================
Files 1721 1721
Lines 64477 64481 +4
Branches 6795 6795
==========================================
- Hits 42858 42743 -115
- Misses 19891 20010 +119
Partials 1728 1728
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| """ | ||
| items = kwargs["rison"] | ||
| advanced_data_type = items.get("type") | ||
| if not advanced_data_type: |
There was a problem hiding this comment.
Rison automatically parses the query string from the defined json schema
* fix: advanced data type API spec and permission name * fix openAPI spec * fix query schema * fix query schema * fix query schema
* fix: advanced data type API spec and permission name * fix openAPI spec * fix query schema * fix query schema * fix query schema
SUMMARY
Simple fix for the new advanced type REST API, we currently use
can_readpermissions instead of FAB defaultcan_getalso simplified the OpenAPI spec and added the rison schema to the decorator so that JSON schema will actually be evaluated
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION