-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(homepage): make to show indicator when tab is chosen #20048
fix(homepage): make to show indicator when tab is chosen #20048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20048 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1712 1712
Lines 64083 64083
Branches 6744 6744
=======================================
Hits 42523 42523
Misses 19847 19847
Partials 1713 1713
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The approach here seems perfectly fine, but I just want to check in with @jess-dillard to see if the Design team has anything different they'd like to see in the visual treatment, which might exist (or need to exist) in our burgeoning design system. |
We don't have a cohesive component for tabs yet, so this looks fine to me! |
🏷️ preset:2022.19 |
(cherry picked from commit ded9122)
SUMMARY
[home page] no indicator for which tab is chosen on recent/dashboard/charts/save query section
Tabs in recents/dashboards/charts/save queries should be indicator when those are chosen.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
Repro steps
1, go to home page
2, click on the tabs in recents/dashboards/charts/save queries
ADDITIONAL INFORMATION