-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chart & explore): Show labels for SliderControl
#19765
Conversation
superset-frontend/src/explore/components/controls/SliderControl.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/explore/components/controls/SliderControl.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #19765 +/- ##
==========================================
- Coverage 66.51% 66.34% -0.17%
==========================================
Files 1687 1690 +3
Lines 64618 64617 -1
Branches 6646 6656 +10
==========================================
- Hits 42978 42871 -107
- Misses 19940 20045 +105
- Partials 1700 1701 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SliderControl
* fix(chart & explore): make to show label of slidercontrol * fix(chart & explore): make to update SliderControl props * fix(chart & explore): make to fix lint (cherry picked from commit dfbaba9)
* fix(chart & explore): make to show label of slidercontrol * fix(chart & explore): make to update SliderControl props * fix(chart & explore): make to fix lint
* fix(chart & explore): make to show label of slidercontrol * fix(chart & explore): make to update SliderControl props * fix(chart & explore): make to fix lint
SUMMARY
[Charts in explore] Labels are missing for some controls on Customize tab (Graph chart)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce issues
This issue is happened on some other charts as well as Graph chart
ADDITIONAL INFORMATION