Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explore): Implement data panel redesign #19751

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 18, 2022

SUMMARY

This PR implements the redesign of data panel in Explore (below the chart container).

  1. Removed the "Data" header that expands/collapses on click
  2. Moved expand/collapse functionality to tabs header. When collapsed, clicking on expand button opens tabs showing "Results" by default OR the last active tab before collapsing
  3. When collapsed, user can also click on tab name to expand with that tab active
  4. When expanded, user can hide the tables by clicking on collapse button OR by clicking on active tab name
  5. Moved row count, copy button and search from tabs header to tab content - now they look more in context of currently displayed table
  6. Now Results and Samples have separate searches - the search text is no longer shared between those 2 tables
  7. Refactored ChartPanel - now we no longer manually calculate widths and heights of chart panel and tables panel. It's all based on css flex.
  8. Tables functionality remains unchanged - the request is sent only when the table is activated the first time or there were changes to query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image
image

After:
image
image

TESTING INSTRUCTIONS

  1. Create a chart
  2. Verify that collapsing/expanding works as described in PR's summary
  3. Verify that copy button and row counter work as before for both results and samples
  4. Verify that typing search text in 1 table doesn't affect search filter in second table
  5. Verify that chart panel and data table panel don't overflow on each other and scale well when window width changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@kgabryje kgabryje changed the title Feat/datapanel redesign feat(explore): Implement data panel redesign Apr 18, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #19751 (90a114a) into master (57157c8) will decrease coverage by 0.01%.
The diff coverage is 78.00%.

@@            Coverage Diff             @@
##           master   #19751      +/-   ##
==========================================
- Coverage   66.51%   66.50%   -0.02%     
==========================================
  Files        1687     1687              
  Lines       64620    64605      -15     
  Branches     6646     6646              
==========================================
- Hits        42980    42963      -17     
- Misses      19940    19945       +5     
+ Partials     1700     1697       -3     
Flag Coverage Δ
javascript 51.16% <78.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../explore/components/ExploreViewContainer/index.jsx 52.90% <ø> (-1.99%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 68.51% <70.58%> (-5.10%) ⬇️
...nd/src/explore/components/DataTablesPane/index.tsx 71.55% <79.31%> (-2.13%) ⬇️
.../src/explore/components/DataTableControl/index.tsx 72.00% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57157c8...90a114a. Read the comment docs.

@kgabryje
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://52.42.171.63:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit 594523e into apache:master Apr 19, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* feat(explore): Redesign of data panel

* Auto calculate chart panel height and width

* Add tests

* Fix e2e tests

* Increase collapsed data panel height
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants