-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Filter dependencies are not being applied in default values #19698
fix: Filter dependencies are not being applied in default values #19698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19698 +/- ##
==========================================
+ Coverage 66.47% 66.51% +0.04%
==========================================
Files 1681 1684 +3
Lines 64467 64572 +105
Branches 6607 6627 +20
==========================================
+ Hits 42856 42952 +96
- Misses 19917 19924 +7
- Partials 1694 1696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://34.222.11.132:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Ephemeral environment shutdown and build artifacts deleted. |
) (cherry picked from commit 7bc9123)
SUMMARY
Fixes a bug where the default values of a filter were not being filtered by their dependencies.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-04-13.at.3.26.38.PM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION