Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db & connection): make to show/hide the password when only creating db connection #19694

Merged
merged 4 commits into from
Apr 26, 2022
Merged

fix(db & connection): make to show/hide the password when only creating db connection #19694

merged 4 commits into from
Apr 26, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Apr 13, 2022 •
edited
Loading

SUMMARY

Show/Hide Password in Database Connection Creation Dynamic Forms

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
Screen Shot 2022-04-13 at 7 53 46 AM
Screen Shot 2022-04-13 at 7 53 57 AM

TESTING INSTRUCTIONS

Proposed changes:

  1. By default, anything typed in the password field should be masked
  2. User should be able to toggle to see the password and toggle back to hiding the password ONLY WHEN entering the password when CONNECTING a database, not when EDITING one
  3. When editing an existing db connection the password should be masked WITHOUT the option to show the password to prevent unintentionally showing passwords to someone who didn't initially connect the db
  4. See details in comment on show/hide icon and tooltip text

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

codemaster08240328
codemaster08240328 approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@codemaster08240328 codemaster08240328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yousoph
Copy link
Member

yousoph commented Apr 14, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.166.83.249:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented Apr 15, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://35.88.99.67:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #19694 (4b7de08) into master (28742e5) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master   #19694   +/-   ##
=======================================
  Coverage   66.38%   66.38%           
=======================================
  Files        1692     1692           
  Lines       64802    64806    +4     
  Branches     6657     6659    +2     
=======================================
+ Hits        43021    43024    +3     
  Misses      20081    20081           
- Partials     1700     1701    +1
Flag Coverage Δ
javascript 51.25% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/components/Form/LabeledErrorBoundInput.tsx 95.00% <75.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28742e5...4b7de08. Read the comment docs.

@rusackas rusackas merged commit 1d043e5 into apache:master Apr 26, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@prosdev0107
fix(db & connection): make to show/hide the password when only creati…
156b0e5 
…ng db connection (apache#19694)

* fix(db & connection): make to show/hide the password when only creating db connection

* fix(db & connection): make to fix unit test of Database Modal
sadpandajoe added a commit to preset-io/superset that referenced this pull request May 13, 2022
@sadpandajoe
Revert "fix(db & connection): make to show/hide the password when onl…
f378eaf 
…y creating db connection (apache#19694)"

This reverts commit 1d043e5.
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@prosdev0107 @philipher29
fix(db & connection): make to show/hide the password when only creati…
07fb232 
…ng db connection (apache#19694)

* fix(db & connection): make to show/hide the password when only creating db connection

* fix(db & connection): make to fix unit test of Database Modal
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AAfghahi AAfghahi AAfghahi approved these changes

@codemaster08240328 codemaster08240328 codemaster08240328 approved these changes

@diegomedina248 diegomedina248 diegomedina248 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@prosdev0107 @yousoph @diegomedina248 @codemaster08240328 @AAfghahi @mistercrunch @rusackas