-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): make to show the null value as N/A in view result #19603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superset-frontend/src/explore/components/DataTableControl/index.tsx
Outdated
Show resolved
Hide resolved
diegomedina248
approved these changes
Apr 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #19603 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64310 +18
Branches 6564 6566 +2
==========================================
+ Hits 42854 42884 +30
+ Misses 19736 19732 -4
+ Partials 1702 1694 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
approved these changes
Apr 13, 2022
villebro
pushed a commit
that referenced
this pull request
Apr 25, 2022
* fix(explore): make to show the null value as N/A in view result * fix(explore): make to remove console * fix(explore): make to remove console in Cell * fix(explore): make to translate N/A (cherry picked from commit 34323f9)
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…he#19603) * fix(explore): make to show the null value as N/A in view result * fix(explore): make to remove console * fix(explore): make to remove console in Cell * fix(explore): make to translate N/A
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 2.0.0
labels
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
NULL values not showing up in View Results in Explore
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce bugs
ADDITIONAL INFORMATION