Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): make to show the null value as N/A in view result #19603

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

prosdev0107
Copy link
Contributor

SUMMARY

NULL values not showing up in View Results in Explore

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

How to reproduce bugs

  1. Go to Explore.
  2. Create or Open the Table Chart
  3. When looking at a table with Null values, the View Results section didn't show the null values.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Apr 7, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #19603 (12f1a74) into master (f91f83d) will increase coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #19603      +/-   ##
==========================================
+ Coverage   66.65%   66.68%   +0.02%     
==========================================
  Files        1680     1681       +1     
  Lines       64292    64310      +18     
  Branches     6564     6566       +2     
==========================================
+ Hits        42854    42884      +30     
+ Misses      19736    19732       -4     
+ Partials     1702     1694       -8     
Flag Coverage Δ
javascript 51.52% <50.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/DataTableControl/index.tsx 70.66% <50.00%> (-0.96%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 52.08% <0.00%> (-0.30%) ⬇️
...ntend/packages/superset-ui-core/src/color/utils.ts 100.00% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.79% <0.00%> (ø)
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91f83d...12f1a74. Read the comment docs.

@rusackas rusackas merged commit 34323f9 into apache:master Apr 19, 2022
villebro pushed a commit that referenced this pull request Apr 25, 2022
* fix(explore): make to show the null value as N/A in view result

* fix(explore): make to remove console

* fix(explore): make to remove console in Cell

* fix(explore): make to translate N/A

(cherry picked from commit 34323f9)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…he#19603)

* fix(explore): make to show the null value as N/A in view result

* fix(explore): make to remove console

* fix(explore): make to remove console in Cell

* fix(explore): make to translate N/A
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants