Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): avoid crash if database missing #19582

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Apr 7, 2022

SUMMARY

When a dataset is referencing a database that is no longer present, trying to edit the dataset fails:

image

After the fix, it's possible to change edit the dataset as expected:
image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #19582 (0cfdd8e) into master (e1ef2ba) will increase coverage by 0.06%.
The diff coverage is 54.34%.

❗ Current head 0cfdd8e differs from pull request most recent head a32b27b. Consider uploading reports for the commit a32b27b to get more accurate results

@@            Coverage Diff             @@
##           master   #19582      +/-   ##
==========================================
+ Coverage   66.59%   66.65%   +0.06%     
==========================================
  Files        1682     1680       -2     
  Lines       64321    64280      -41     
  Branches     6561     6564       +3     
==========================================
+ Hits        42837    42849      +12     
+ Misses      19783    19729      -54     
- Partials     1701     1702       +1     
Flag Coverage Δ
javascript 51.46% <37.03%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 36.19% <ø> (ø)
.../legacy-plugin-chart-country-map/src/CountryMap.js 0.00% <ø> (ø)
...y-plugin-chart-country-map/src/ReactCountryMap.jsx 0.00% <0.00%> (ø)
...y-plugin-chart-sankey-loop/src/ReactSankeyLoop.jsx 0.00% <0.00%> (ø)
.../legacy-plugin-chart-sankey-loop/src/SankeyLoop.js 0.00% <ø> (ø)
...-chart-deckgl/src/layers/Screengrid/Screengrid.jsx 0.00% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts 0.00% <0.00%> (-11.12%) ⬇️
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 33.33% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <0.00%> (-0.35%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ef2ba...a32b27b. Read the comment docs.

@villebro villebro merged commit db21351 into apache:master Apr 7, 2022
@villebro villebro deleted the villebro/missing-database branch April 7, 2022 10:43
villebro added a commit that referenced this pull request Apr 8, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants