Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct Ukraine map #19528

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix: Correct Ukraine map #19528

merged 2 commits into from
Apr 5, 2022

Conversation

wacken89
Copy link
Contributor

@wacken89 wacken89 commented Apr 5, 2022

SUMMARY

Fix Ukraine map:

  • Crimea is a part of Ukraine
  • Right pronunciation of Kyiv (not Kiev)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

image

Roman Pridybailo and others added 2 commits March 28, 2022 17:14
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #19528 (edd0562) into master (6b9113a) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19528      +/-   ##
==========================================
- Coverage   66.48%   66.44%   -0.05%     
==========================================
  Files        1670     1677       +7     
  Lines       63952    64173     +221     
  Branches     6506     6539      +33     
==========================================
+ Hits        42519    42637     +118     
- Misses      19747    19841      +94     
- Partials     1686     1695       +9     
Flag Coverage Δ
javascript 51.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <0.00%> (-38.32%) ⬇️
...set-frontend/src/components/ReportModal/styles.tsx 87.50% <0.00%> (-12.50%) ⬇️
.../components/Header/HeaderActionsDropdown/index.jsx 67.79% <0.00%> (-3.64%) ⬇️
...rset-frontend/src/components/ReportModal/index.tsx 78.46% <0.00%> (-3.63%) ⬇️
...ontend/src/dashboard/components/dnd/DragHandle.tsx 83.33% <0.00%> (-2.39%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 70.88% <0.00%> (-1.85%) ⬇️
...tend/src/components/Datasource/DatasourceModal.tsx 69.04% <0.00%> (-1.69%) ⬇️
...d/src/explore/components/PropertiesModal/index.tsx 68.85% <0.00%> (-1.15%) ⬇️
...atasourcePanel/DatasourcePanelDragOption/index.tsx 88.88% <0.00%> (-1.12%) ⬇️
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 43.85% <0.00%> (-0.97%) ⬇️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b9113a...edd0562. Read the comment docs.

@kgabryje kgabryje changed the title Correct Ukraine map fix: Correct Ukraine map Apr 5, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! General note about contested areas (quote from the generator notebook): "For disputed territories, we respect each country and give them what they want." So certain territories may show up on multiple country maps.

@villebro villebro merged commit cccec9a into apache:master Apr 5, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Crimea

* Update ukraine.geojson

Co-authored-by: Roman Pridybailo <rp@vaix.ai>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
@rusackas
Copy link
Member

This PR's geojson was overwritten by the Jupyter notebook, which pulls data from Natural Earth, which in turn (sadly/errantly) does not include Crimea. In the future, all changes/fixes on map data should be made in the Jupyter notebook so that this sort of regression does not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants