-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct Ukraine map #19528
fix: Correct Ukraine map #19528
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19528 +/- ##
==========================================
- Coverage 66.48% 66.44% -0.05%
==========================================
Files 1670 1677 +7
Lines 63952 64173 +221
Branches 6506 6539 +33
==========================================
+ Hits 42519 42637 +118
- Misses 19747 19841 +94
- Partials 1686 1695 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution! General note about contested areas (quote from the generator notebook): "For disputed territories, we respect each country and give them what they want." So certain territories may show up on multiple country maps.
* Crimea * Update ukraine.geojson Co-authored-by: Roman Pridybailo <rp@vaix.ai>
This PR's geojson was overwritten by the Jupyter notebook, which pulls data from Natural Earth, which in turn (sadly/errantly) does not include Crimea. In the future, all changes/fixes on map data should be made in the Jupyter notebook so that this sort of regression does not happen again. |
SUMMARY
Fix Ukraine map:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF