Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing init on python pkg key_value #19428

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

Adds missing __init__.py on key_value pkg

Getting:

  File "/usr/local/lib/python3.8/site-packages/superset/views/access_requests.py", line 25, in <module>
    from superset.views.core import DAR
  File "/usr/local/lib/python3.8/site-packages/superset/views/core.py", line 74, in <module>
    from superset.dashboards.permalink.commands.get import GetDashboardPermalinkCommand
  File "/usr/local/lib/python3.8/site-packages/superset/dashboards/permalink/commands/get.py", line 28, in <module>
    from superset.key_value.commands.get import GetKeyValueCommand
ModuleNotFoundError: No module named 'superset.key_value.commands'

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 How did this not get picked up earlier?? Thanks for fixing!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19428 (f8e309d) into master (a8e7624) will decrease coverage by 0.05%.
The diff coverage is 60.00%.

❗ Current head f8e309d differs from pull request most recent head 458affe. Consider uploading reports for the commit 458affe to get more accurate results

@@            Coverage Diff             @@
##           master   #19428      +/-   ##
==========================================
- Coverage   66.59%   66.53%   -0.06%     
==========================================
  Files        1670     1670              
  Lines       63884    63888       +4     
  Branches     6510     6510              
==========================================
- Hits        42542    42509      -33     
- Misses      19653    19690      +37     
  Partials     1689     1689              
Flag Coverage Δ
hive 52.64% <0.00%> (-0.27%) ⬇️
mysql 81.89% <60.00%> (-0.01%) ⬇️
postgres 81.94% <60.00%> (-0.01%) ⬇️
presto ?
python 82.26% <60.00%> (-0.12%) ⬇️
sqlite 81.71% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/key_value/commands/create.py 93.47% <ø> (ø)
superset/key_value/commands/update.py 89.36% <ø> (ø)
superset/dashboards/permalink/commands/create.py 89.65% <50.00%> (-2.94%) ⬇️
superset/explore/permalink/commands/create.py 90.62% <50.00%> (-2.71%) ⬇️
superset/key_value/commands/upsert.py 89.58% <100.00%> (ø)
superset/db_engine_specs/presto.py 84.30% <0.00%> (-4.82%) ⬇️
superset/connectors/sqla/models.py 88.28% <0.00%> (-1.03%) ⬇️
superset/models/core.py 88.80% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e7624...458affe. Read the comment docs.

@dpgaspar
Copy link
Member Author

😱 How did this not get picked up earlier?? Thanks for fixing!

No problem, thks for the review

@dpgaspar dpgaspar merged commit fa35109 into apache:master Mar 30, 2022
@dpgaspar dpgaspar deleted the fix/missing-pkg-init-key-value branch March 30, 2022 11:47
@villebro villebro added the lts-v1 label Apr 1, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* fix: add missing init on python pkg key_value

* fix lint issues

* fix lint issues

(cherry picked from commit fa35109)
villebro pushed a commit that referenced this pull request Apr 4, 2022
* fix: add missing init on python pkg key_value

* fix lint issues

* fix lint issues

(cherry picked from commit fa35109)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix: add missing init on python pkg key_value

* fix lint issues

* fix lint issues
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/M 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants