-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: linear imputation in Resample #19393
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19393 +/- ##
==========================================
- Coverage 66.48% 66.46% -0.03%
==========================================
Files 1670 1670
Lines 63952 63958 +6
Branches 6506 6506
==========================================
- Hits 42519 42509 -10
- Misses 19747 19763 +16
Partials 1686 1686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiice! Two minor nits, other than that really looking forward to getting this merged 👍
superset-frontend/packages/superset-ui-chart-controls/src/sections/advancedAnalytics.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit a39dd44)
SUMMARY
Adding a new
resample method
: linear imputationBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
download DailyDelhiClimateTrain.csv and create a new dataset in your local. (Use PostgreSQL as current testing)
open explore page and select DailyDelhiClimateTrain dataset
change viz type to
Bar Chart
, notice that you should pick up echart versiondrag date in X-Axis
set time range from
2014-12-10
to2014-12-20
set metric to
MAX(meantemp)::INTEGER
set filter to
date not in ('2014-12-11'::TIMESTAMP, '2014-12-12'::TIMESTAMP)
you get a bar chart without data for
12-11 and 12-12
.select
1 calendar day frequency
andLinear imputation
in Advanced analytics panel, then clickRun
.ADDITIONAL INFORMATION