Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(native filter): add new test for dependent filter #19392

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

jinghua-qa
Copy link
Member

@jinghua-qa jinghua-qa commented Mar 28, 2022

add new test: User can create parent filters using "Values are dependent on other filters"'

SUMMARY

1, add cleanup function for native filter test to remove copy of test dashboard
2, add new test for dependent filter

Will have the command function applied to other test in a separated PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #19392 (17cf6d6) into master (6f57782) will increase coverage by 0.08%.
The diff coverage is 75.73%.

❗ Current head 17cf6d6 differs from pull request most recent head 0d99039. Consider uploading reports for the commit 0d99039 to get more accurate results

@@            Coverage Diff             @@
##           master   #19392      +/-   ##
==========================================
+ Coverage   66.48%   66.57%   +0.08%     
==========================================
  Files        1670     1675       +5     
  Lines       63952    64092     +140     
  Branches     6506     6519      +13     
==========================================
+ Hits        42519    42669     +150     
+ Misses      19747    19730      -17     
- Partials     1686     1693       +7     
Flag Coverage Δ
javascript 51.24% <42.98%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrols/src/components/CertifiedIconWithTooltip.tsx 80.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx 33.33% <ø> (ø)
...omponents/ColumnConfigControl/ColumnConfigItem.tsx 0.00% <ø> (ø)
...erset-frontend/src/SqlLab/components/App/index.jsx 55.55% <ø> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Icons/Icon.tsx 95.23% <ø> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx 67.79% <0.00%> (-3.64%) ⬇️
...tiveFilters/FiltersConfigModal/DraggableFilter.tsx 71.87% <ø> (ø)
...ontend/src/dashboard/containers/DashboardRoute.tsx 0.00% <0.00%> (ø)
... and 148 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f57782...0d99039. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 29, 2022

Cypress.Commands.add('deleteDashboardByName', (name: string) =>
cy.getDashboards().then(dashboards => {
for (const element of dashboards) {
Copy link
Member

@stephenLYZ stephenLYZ Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here may use forEach instead of for...of.


Cypress.Commands.add('deleteChartByName', (name: string) =>
cy.getCharts().then(slices => {
for (const element of slices) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jinghua-qa jinghua-qa merged commit 2a75e4c into apache:master Apr 1, 2022
@villebro villebro added the lts-v1 label Apr 1, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* add new test for dependent filter

(cherry picked from commit 2a75e4c)
villebro pushed a commit that referenced this pull request Apr 4, 2022
* add new test for dependent filter

(cherry picked from commit 2a75e4c)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io Preset-QA size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants