-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(native filter): add new test for dependent filter #19392
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19392 +/- ##
==========================================
+ Coverage 66.48% 66.57% +0.08%
==========================================
Files 1670 1675 +5
Lines 63952 64092 +140
Branches 6506 6519 +13
==========================================
+ Hits 42519 42669 +150
+ Misses 19747 19730 -17
- Partials 1686 1693 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
||
Cypress.Commands.add('deleteDashboardByName', (name: string) => | ||
cy.getDashboards().then(dashboards => { | ||
for (const element of dashboards) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here may use forEach
instead of for...of
.
|
||
Cypress.Commands.add('deleteChartByName', (name: string) => | ||
cy.getCharts().then(slices => { | ||
for (const element of slices) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
* add new test for dependent filter (cherry picked from commit 2a75e4c)
* add new test for dependent filter (cherry picked from commit 2a75e4c)
* add new test for dependent filter
add new test: User can create parent filters using "Values are dependent on other filters"'
SUMMARY
1, add cleanup function for native filter test to remove copy of test dashboard
2, add new test for dependent filter
Will have the command function applied to other test in a separated PR
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION