Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(embedded): download chart as image #19339

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix(embedded): download chart as image #19339

merged 1 commit into from
Mar 23, 2022

Conversation

lilykuang
Copy link
Member

This pr fixes the issue for downloading charts as image, the download file dialog box was not showing up with iframe

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from suddjian March 23, 2022 19:00
@lilykuang lilykuang merged commit 0ad6925 into apache:master Mar 23, 2022
@lilykuang lilykuang deleted the embedded-download-as-image branch March 23, 2022 21:04
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 31, 2022
@sadpandajoe
fix(embedded): download chart as image (apache#19339)
c32ddb1 
(cherry picked from commit 0ad6925)
villebro pushed a commit that referenced this pull request Apr 3, 2022
@villebro
fix(embedded): download chart as image (#19339)
b21d4f8 
(cherry picked from commit 0ad6925)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@philipher29
fix(embedded): download chart as image (apache#19339)
4d85136
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian suddjian approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilykuang @sadpandajoe @suddjian @mistercrunch @villebro