-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regression on Select component when handling null values #19326
fix: regression on Select component when handling null values #19326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19326 +/- ##
=======================================
Coverage 66.65% 66.65%
=======================================
Files 1674 1674
Lines 64603 64605 +2
Branches 6500 6501 +1
=======================================
+ Hits 43058 43060 +2
Misses 19862 19862
Partials 1683 1683
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix and the added tests @diegomedina248!
🏷️ preset:2022.11 |
(cherry picked from commit 9e58916)
Can you please tell me how to hide or ignore NULL values from native filter, or use dataset with no values even NULL ? |
SUMMARY
PR #19283 reintroduced an issue when handling null values in the Select component.
This PR fixes that & adds tests to catch further regressions around it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-03-23.at.08.50.12.mov
After:
Screen.Recording.2022-03-23.at.08.49.06.mov
TESTING INSTRUCTIONS
Check video for instructions
ADDITIONAL INFORMATION